Site Editor: Use server definition for the Template Areas #37215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
Dec 8, 2021
Comment on lines
+28
to
+30
| return defaultAreas.find( | ||
| ( defaultArea ) => defaultArea.area === area | ||
| ); |
There was a problem hiding this comment.
I doubt myself this morning, but this will correctly pass isShallowEqual check if the returned item is the same, right? 😄
|
Size Change: +21 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Mamaduka
added
[Feature] Site Editor
|
@jameskoster, I think we should include the "Navigation" icon in the |
kevin940726
approved these changes
Dec 8, 2021
kevin940726
added
the
Backport to WP 6.7 Beta/RC
Agreed. We also need to make it possible to edit the template part properties whilst editing it in focus mode. |
|
Thanks for testing, @kevin940726, and @jameskoster. I can do a quick follow-up for the Navigation icon; it should be a small PR.
Do we have an issue for this? |
|
No, I'll make one :) Edit: #37220 |
|
I'm going to merge this. Failing e2e tests is caused by a known issue - a bad request when fetching nonces. |
|
Thanks @Mamaduka! |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Site Editor: Use server definition for the Template Areas * Simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #36955.
Updates template details components to use server-side definitions for the Template Areas. In addition, it will allow correctly displaying custom areas registered by themes. If the custom area isn't registered, it will fall back to the "General" area.
How has this been tested?
navin the area field.For testing, you can also use the Wowmall theme.
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).