Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Areas UI: Add support for other area types #36955

Closed
jameskoster opened this issue Nov 29, 2021 · 4 comments · Fixed by #37215
Closed

Template Areas UI: Add support for other area types #36955

jameskoster opened this issue Nov 29, 2021 · 4 comments · Fixed by #37215
Assignees
@Mamaduka
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

I was testing some FSE themes from the directory last week and spotted what I suspect is a bug:

Screenshot 2021-11-29 at 12 36 52

The areas UI currently only seems to support Template Parts that are assigned to either the header or footer area. Other Template Parts (IE those assigned to the navigation or sidebar area) appear to be broken in the areas UI.
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Full Site Editing [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 29, 2021
@jameskoster
Copy link
Contributor Author

The same issue appears in the template dropdown:

Screenshot 2021-11-29 at 12 40 27

@noisysocks noisysocks added the [Priority] High Used to indicate top priority items that need quick attention label Dec 1, 2021
@noisysocks
Copy link
Member

noisysocks commented Dec 1, 2021 •
edited
Loading

@jameskoster: What theme are you using to reproduce this?

@jameskoster
Copy link
Contributor Author

@noisysocks Wowmall.

@Mamaduka
Copy link
Member

Mamaduka commented Dec 7, 2021

I started working on the fix and will have PR ready for testing tomorrow.

@Mamaduka Mamaduka self-assigned this Dec 7, 2021
@Mamaduka Mamaduka added the [Status] In Progress Tracking issues with work in progress label Dec 7, 2021
@Mamaduka Mamaduka mentioned this issue Dec 8, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor: Use server definition for the Template Areas WordPress/gutenberg
3 participants
@Mamaduka @noisysocks @jameskoster