Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Cannot type in the Link Input dialog when in a paragraph #3468

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

tg-ephox
Copy link
Contributor

@tg-ephox tg-ephox commented Nov 14, 2017

Description

fixes #3466
fixes #3467

How Has This Been Tested?

Manual, unit tests

Screenshots (jpeg or gifs if applicable):

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@BoardJames BoardJames added the [Type] Bug An existing feature does not function as intended label Nov 14, 2017
@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #3468 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3468      +/-   ##
==========================================
+ Coverage   33.83%   33.92%   +0.08%     
==========================================
  Files         253      253              
  Lines        6741     6745       +4     
  Branches     1223     1225       +2     
==========================================
+ Hits         2281     2288       +7     
+ Misses       3761     3759       -2     
+ Partials      699      698       -1
Impacted Files Coverage Δ
components/slot-fill/fill.js 75% <100%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ccd85...652dd5d. Read the comment docs.

@tg-ephox tg-ephox requested a review from youknowriad November 14, 2017 07:11
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Nice fix and test 👍

@youknowriad youknowriad merged commit 0aee803 into master Nov 14, 2017
@youknowriad youknowriad deleted the fix/3466-cannot-type-link-input branch November 14, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format toolbar not reflecting current editor state Cannot type in the Link Input dialog when in a paragraph
3 participants