Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format toolbar not reflecting current editor state #3467

Closed
ephox-mogran opened this issue Nov 14, 2017 · 1 comment · Fixed by #3468
Closed

Format toolbar not reflecting current editor state #3467

ephox-mogran opened this issue Nov 14, 2017 · 1 comment · Fixed by #3468
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@ephox-mogran
Copy link
Contributor

Issue Overview

The bold, italic buttons etc. are not reflecting the current editor state as you move the cursor (via keyboard or clicking).

Steps to Reproduce (for bugs)

  1. Create a new paragraph
  2. Select one of the words and make it bold
  3. Move the cursor around in that paragraph

Expected Behavior

The bold state reflects where the cursor is

Current Behavior

The bold state gets out of sync.

Possible Solution

This looks like it is also an issue with how the slot is not updating when non bubbling virtually. The related issue is #3466 . @tg-ephox is creating a PR for this fix.
@tg-ephox tg-ephox mentioned this issue Nov 14, 2017
Merged
3 tasks
@mtias mtias added [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended labels Nov 14, 2017
@mtias
Copy link
Member

mtias commented Nov 14, 2017

It seems this affects more than just inline formatting. If you switch the quote style the toolbar state doesn't update:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX - Cannot type in the Link Input dialog when in a paragraph WordPress/gutenberg
2 participants
@mtias @ephox-mogran