WordPress 5.8.1 backports #34393
Merged
WordPress 5.8.1 backports #34393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 626f233)
(cherry picked from commit 8afca1e)
* Widgets: Allow HTML tags in description * Use `dangerouslySetInnerHTML` Avoid `<div />` inside the `<p />` tag * Describe by dangerouslySetInnerHTML is used * Use safeHTML * Update comment
Don't include terms that aren't assigned to any posts as "most used" terms.
…33679) * FontSizePicker: Don't use units if the value is a number * Add unit tests * Disable units when we have number values
* Remove margin setting, auto right conflict with justify buttons * Per review, add little margin back
* Add error boundary to edit widgets screen * Add error boundary to customize widgets * Refactor sidebar controls provider to application level so that its state is not lost when re-initializing * Revert "Refactor sidebar controls provider to application level so that its state is not lost when re-initializing" This reverts commit 7d607ff. * Remove rebootability from customize widgets * Remove debug code
This updates the default batch processor to make multiple batch requests if the number of requests to process exceeds the number of requests that the batch endpoint can handle. We determine the number of requests that the batch endpoint can handle by making a preflight OPTIONS request to /batch/v1. By default it is 25 requests. See https://make.wordpress.org/core/2020/11/20/rest-api-batch-framework-in-wordpress-5-6/.
* Rework button block link UI to match RichText format implementation * Refine some more, determine visibility by selection and url state * Add e2e test * Also focus rich text when unlinking using a keyboard shortcut
|
Size Change: +1.43 kB (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
It needs to be investigated. It should be an easy fix. We need to add a missing import statement: import { store as editorStore } from '@wordpress/editor'; |
|
Also, I know some of the commits cherry picked here were not marked with the label or appropriate milestone. My reasoning for including the first 4 commits in the list above was to avoid some problematic merge conflicts in the other commits that followed these. It may result in a few more packages being updated than necessary for the release, but it will make backporting any PRs with README updates much easier during 5.8.x. |
|
Adding also these two Reusable block PRs |
Looks like #30617 depends on #34170, and the latter isn't included in this PR. Adding the missing import would help, but the argument in the calls to |
gziolo
added
Backport to WP Minor Release
The simpler way would be to access the name of the story through the imported object so we don't have to bring more unrelated code from #34170: import { store as editorStore } from '@wordpress/editor';
controls.select( edtiorStore.name ).selector();
That's a good strategy. I was initially surprised seeing some of PRs on the list, but it all makes sense 👍🏻 |
Yep, that's what I was suggesting 😄 |
In my opinion, both of these feel like they are bug fixes by way of enhancement/refinement and I think I'm more comfortable waiting until 5.9 to include these. If a few Gutenberg leads feel that this is important and low risk enough to include, I'm happy to reconsider. @talldan @gziolo would either of you be able to perform a partial cherry pick of the needed code? It's not clear to me where those imports would need to take place. |
|
@desrosj, any idea why some (or even all) CI jobs run twice when targeting WP release branches? I added two commits that should make static analysis CI jobs pass. |
|
Thanks!
Ah that is my fault. They are running twice because they are configured to happen on Looks like the performance tests are failing, but the failing test is a timeout. I've restarted it. |
6 tasks
This is a partial cherry pick of 2356b2d in order to fix the performance tests.
desrosj
requested review from
adamsilverstein,
adamziel,
ajitbohra,
cameronvoell,
chrisvanpatten,
dmsnell,
draganescu,
ellatrix,
guarani,
gziolo,
kevin940726,
nerrad,
noisysocks,
ntwb,
spacedmonkey,
swissspidy,
talldan,
tellthemachines and
TimothyBJacobs
as code owners
gziolo
approved these changes
Sep 1, 2021
|
Just noting that the failing end-to-end tests were run on the |
noisysocks
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cherry picks the following commits to the
wp/5.8branch for inclusion in WordPress 5.8.1 (RC due out Wednesday, September 1, 2021.Partial cherry pick:
Trac ticket: https://core.trac.wordpress.org/ticket/54052.
Checklist:
*.native.jsfiles for terms that need renaming or removal).