Try to fix flaky customizer inspector test #33890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Widgets Customizer
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Aug 5, 2021
|
We disabled the plugin for the tests to work. See #32024 for more info. We do plan to fix that though in the future, but it's related to core so a bit more complicated to fix. |
|
I just got the same failure on trunk https://github.com/WordPress/gutenberg/runs/3281574200. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #33875, part of #33275.
During closing the inspector and going back to the editor, the transition is making the blocks positioning in an intermediate state. Since the toolbar is still opened, it could sometimes also be positioned in the wrong place according to intermediate state of the block.
This PR waits for the transition to finish (200ms). A better alternative could be:
How has this been tested?
Not yet found a reliable way to reproduce the issue, so maybe we just have to merge this and monitor it on trunk.
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).