Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate unstable widgets test #33275

Open
talldan opened this issue Jul 8, 2021 · 7 comments
Open

Investigate unstable widgets test #33275

talldan opened this issue Jul 8, 2021 · 7 comments
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.

Comments

@talldan
Copy link
Contributor

talldan commented Jul 8, 2021

Description

This widgets test seems to be failing in trunk:
https://github.com/WordPress/gutenberg/runs/3014495507

FAIL specs/widgets/editing-widgets.test.js (114 s)
  ● Widgets screen › Should insert content using the inline inserter

    expect(received).toMatchInlineSnapshot(snapshot)

    Snapshot name: `Widgets screen Should insert content using the inline inserter 1`

    - Snapshot  - 9
    + Received  + 1

      Object {
    -   "sidebar-1": "<div class=\"widget widget_block widget_text\"><div class=\"widget-content\">
    - <p>First Paragraph</p>
    - </div></div>
    - <div class=\"widget widget_block\"><div class=\"widget-content\">
    - <h2>My Heading</h2>
    - </div></div>
    - <div class=\"widget widget_block widget_text\"><div class=\"widget-content\">
    - <p>Second Paragraph</p>
    - </div></div>",
    +   "wp_inactive_widgets": "",
      }

      374 | 		await saveWidgets();
      375 | 		const serializedWidgetAreas = await getSerializedWidgetAreas();
    > 376 | 		expect( serializedWidgetAreas ).toMatchInlineSnapshot( `
          | 		                                ^
      377 | 		Object {
      378 | 		  "sidebar-1": "<div class=\\"widget widget_block widget_text\\"><div class=\\"widget-content\\">
      379 | 		<p>First Paragraph</p>

      at Object.<anonymous> (specs/widgets/editing-widgets.test.js:376:35)

I couldn't see any artifacts for some reason.

@talldan talldan added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Jul 8, 2021
@kevin940726 kevin940726 self-assigned this Jul 8, 2021
@kevin940726
Copy link
Member

I think there're no artifacts because the test completed, it just failed to match the snapshot. But I do expect it to generate some screenshots though. 🤔

@youknowriad
Copy link
Contributor

I'm skipping two more e2e tests with similar failures here #33547

@youknowriad
Copy link
Contributor

Another related failure #33875 in case anyone has an idea here.

@Mamaduka
Copy link
Member

Mamaduka commented Aug 6, 2021

I spotted another e2e test failure, commenting here so we can keep an eye on it - https://github.com/WordPress/gutenberg/runs/3261461038.

@noisysocks
Copy link
Member

@kevin940726: Was this fixed? Can we close the issue?

@kevin940726
Copy link
Member

Nope, the test is skipped 7 months ago and hasn't been re-enabled yet 😅 . I think we can just re-enable it now that we have a flaky tests reporter and auto-retrying mechanism.

@noisysocks noisysocks added Needs Dev Ready for, and needs developer efforts and removed [Status] In Progress Tracking issues with work in progress labels Feb 7, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
@jordesign
Copy link
Contributor

@kevin940726 did this end up getting re-enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants