Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Details: Avoid PHP notice when parsing protocol-relative icon URLs #33779

Merged
merged 1 commit into from
Jul 30, 2021
Merged

URL Details: Avoid PHP notice when parsing protocol-relative icon URLs #33779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/class-wp-rest-url-details-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ private function get_icon( $html, $url ) {

// If the icon is a data URL, return it.
$parsed_icon = parse_url( $icon );
if ( 'data' === $parsed_icon['scheme'] ) {
if ( isset( $parsed_icon['schema'] ) && 'data' === $parsed_icon['scheme'] ) {
return $icon;
}

Expand Down