URL Details: Avoid PHP notice when parsing protocol-relative icon URLs #33779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sites might use protocol-relative URLs for icons. When a similar URL is parsed with
parse_url
, it doesn't return schema and triggered PHP notice.Example: https://3v4l.org/SFEiZ
How has this been tested?
https://twitter.com/
PHP Notice: Undefined index: scheme
message.Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).