Escape key sanity (avoid event.stopPropagation) #33630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
cameronvoell,
chrisvanpatten and
guarani
as code owners
|
Size Change: +18 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
7 tasks
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
event.stopPropagationcalls in all components after the Escape key is handled. This method should be avoided as it completely stops event bubbling. Components should instead look if Escape has already been handled by checkingevent.defaultPrevented. Components should anyway callevent.preventDefaultafter handling Escape to prevent default browser behaviour.Rule of thumb. Always prevent default behaviour when reacting to key events.
event.defaultPreventedshould generally be false. A component inside the current component could already be reacting to the same key event.Perhaps we could create an ESLint rule for this in the future.
Related: #19879, which mentions the following article: https://css-tricks.com/dangers-stopping-event-propagation/.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).