Block editor: remove focus stopPropagation from appender #32003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 19, 2021
| @@ -18,13 +17,6 @@ import DefaultBlockAppender from '../default-block-appender'; | |||
| import ButtonBlockAppender from '../button-block-appender'; | |||
| import { store as blockEditorStore } from '../../store'; | |||
|
|
|||
| // A Context to store the map of the appender map. | |||
| export const AppenderNodesContext = createContext(); | |||
|
Size Change: -16 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
remove/appender-stop-propagation
branch
from
9f3d333 to
82c280b
Compare
ellatrix
force-pushed
the
remove/appender-stop-propagation
branch
from
82c280b to
7e09d9b
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts
isInsideRootBlockto account for appenders.Related: #33630.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).