Fix broken the post-template-editor test. #32904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate and wp_template_part posts.
7 tasks
|
Size Change: +1 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
gziolo
added
[Type] Automated Testing
gziolo
reviewed
Jun 23, 2021
packages/e2e-tests/specs/experiments/post-editor-template-mode.test.js
Outdated
Show resolved
Hide resolved
7 tasks
|
Nice catch! Can anyone explain why (without this PR applied) the tests pass locally but don't pass on CI? Why would a Plugin not be enabled on CI but it is enabled locally? |
getdave
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
I tested this locally and all Post Template Editor tests pass ✅
CI also now seems to be passing 🎉 🎉 🎉 🎉
The other test failures on this PR appear to be known and unrelated. I think we're good to merge this as soon as @gziolo gives his 👍
We may need to force merge to get around those unrelated test failures which shouldn't block this PR in my opinion.
….test.js Co-authored-by: Greg Ziółkowski <[email protected]>
You probably don't have the same setup locally. It requires the most recent WordPress 5.8 beta instance that contains changes to the conditions when the template editing mode is enabled. |
gziolo
reviewed
Jun 23, 2021
packages/e2e-tests/specs/experiments/post-editor-template-mode.test.js
Outdated
Show resolved
Hide resolved
youknowriad
added
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Change to a theme that supports block-templates, and then delete wp_template and wp_template_part posts.
* add plugin for switch add_theme_support('block-templates')
* Update packages/e2e-tests/specs/experiments/post-editor-template-mode.test.js
Co-authored-by: Greg Ziółkowski <[email protected]>
* Update packages/e2e-tests/specs/experiments/post-editor-template-mode.test.js
Co-authored-by: Greg Ziółkowski <[email protected]>
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Change to a theme that supports block-templates, and then delete wp_template and wp_template_part posts.
* add plugin for switch add_theme_support('block-templates')
* Update packages/e2e-tests/specs/experiments/post-editor-template-mode.test.js
Co-authored-by: Greg Ziółkowski <[email protected]>
* Update packages/e2e-tests/specs/experiments/post-editor-template-mode.test.js
Co-authored-by: Greg Ziółkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related: #32744. #32858.
Post Editor Template mode test broken now. This problem is caused by the fact that "block-templates" is not enabled in the classic theme.
I added a plugin to e2e-tests to solve this problem.
How has this been tested?
npm run test-e2e -- --puppeteer-interactive ./packages/e2e-tests/specs/experiments/post-editor-template-mode.test.jsScreenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).