TemplatePanel: Fixed a problem that when a new template is created, the template is not displayed in the select box. #32744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilableTemplates in editorSettings.
torounit
added
the
[Feature] Template Editing Mode
7 tasks
|
Size Change: +1.05 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 17, 2021
youknowriad
reviewed
Jun 17, 2021
youknowriad
reviewed
Jun 17, 2021
|
In my testing this doesn't seem to solve the issue, do you know why I get "404" there and not the template that was created (I'm testing with tt1-blocks)
|
|
I was able to reproduce the problem. The result of Also, should I show a 404 in this selectbox? |
|
Also, the value of getEditorSettings().availableTemplates is as follows. It's odd that the key for 404 is |
|
Feels like there's two different but related issues at play:
I think we can leave the second point for later as FSE themes are not included in 5.8 |
I cannot reproduce this problem. How do I operate? |
|
@torounit mmm 🤔 trying again, maybe I didn't test properly the first time. |
youknowriad
approved these changes
Jun 18, 2021
|
Looks like the test failure is consistent and I don't see it on trunk, is this something you can check or would you need help for it? |
|
@youknowriad Fixed e2e test. |
youknowriad
reviewed
Jun 21, 2021
| @@ -103,12 +103,15 @@ describe( 'Post Editor Template mode', () => { | |||
| wp.data.dispatch( 'core/block-editor' ).clearSelectedBlock(); | |||
| } ); | |||
|
|
|||
| await createNewTemplate( 'Blank Template' ); | |||
There was a problem hiding this comment.
I don't think we should add this here because it changes what the test is about, this test is about testing block-based themes where you can switch to the template mode for default templates as well.
There was a problem hiding this comment.
Thanks for reviewing !
If we do not create a new template, the only template that exists is the "Defalut Template". In the case of "Defalut Template", the "Edit" link will not appear, and a timeout will occur. Therefore, we need to create an editable template and link it to the post.
There was a problem hiding this comment.
For block-based themes, the default template is editable, and that test switches to "tt1-blocks" in the beginning of the test.
There was a problem hiding this comment.
Sorry, I must have misunderstood. I deleted the new template and it passed the test.
youknowriad
reviewed
Jun 21, 2021
| @@ -53,7 +53,7 @@ function PostTemplateActions() { | |||
| return ( | |||
| <> | |||
| <div className="edit-post-template__actions"> | |||
| { !! template && ( | |||
| { template !== null && ( | |||
There was a problem hiding this comment.
Is the change here intentional? What's the reasoning? I'm just trying to think if there are cases where template could be undefined?
There was a problem hiding this comment.
The one I was verifying the operation of got mixed up.
I will revert to !! template.
|
This is working great, 💯 kudos |
youknowriad
added
the
[Type] Bug
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
After merging this, I noticed that the post-template-editor test is failing on trunk. It's not clear whether it's because of this PR or something else though. Do you think this is something you can help debug @torounit ? |
|
The problem seems to be coming from 46df095. When I set It seems that we need to think about e2e-testing when the theme does not support |
7 tasks
|
@youknowriad Opened PR #32904 about the issue of broken e2e-test. |
|
Great thank you. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
…he template is not displayed in the select box. (#32744)
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
…he template is not displayed in the select box. (#32744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related: #32735.
Fixed instead of __unstableSwitchToTemplateMode.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).