Widget Editor: Hide some settings from the "Options" menu on small screens #32690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Feature] Widgets Screen
|
Size Change: +10 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
I wonder if we should do the same for the Show Block Breadcrumbs setting. That UI also doesn't show on mobile. |
|
That makes sense. |
Mamaduka
changed the title
draganescu
approved these changes
Jun 15, 2021
Mamaduka
force-pushed
the
fix/small-screens-hide-top-toolbar-settings
branch
from
58123d4 to
00e3d30
Compare
noisysocks
added
the
Backport to WP 6.7 Beta/RC
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks to remove the "Top toolbar" and "Show Block Breadcrumbs" settings on small screens.
Fixes #32630.
How has this been tested?
Screenshots
CleanShot.2021-06-15.at.14.46.24.mp4
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).