Theme styles: fix dark theme detection #32496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
Backport to WP 6.7 Beta/RC
|
Size Change: +16 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Looks good, thanks for the fix! |
|
It seems like we landed an alternative fix here #32477 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32470. Since #31870 the editor styles wrapper doesn't have a background color set, so the default background color is transparent, even if the parent element's background color is sit to white. The default color is "transparent", which is "rgba(0, 0, 0, 0)" through
getComputedStyle.tinycolorconsiders this te be be low luminance because it is black and it doesn't seem to consider the opacity.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).