-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assume light theme when editor canvas background color isn't set #32477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
the
[Type] Bug
An existing feature does not function as intended
label
Jun 7, 2021
Size Change: +10 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Jun 7, 2021
tellthemachines
added
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Jun 8, 2021
It works! Thank you! |
youknowriad
pushed a commit
that referenced
this pull request
Jun 8, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jun 8, 2021
7 tasks
youknowriad
pushed a commit
that referenced
this pull request
Jun 8, 2021
ockham
pushed a commit
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32448. The
is-dark-theme
body class is added when a luminance check returns < 0.5, but if no background color is set, the default value is 0, so the body class gets added. This adds a check of the alpha value so that we don't set the dark theme body class if the background is transparent.How has this been tested?
Test by going to wp-admin/widgets.php and checking if the block outline shows when a block is selected.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).