Widgets editor: Improve compatibility with WP 5.8 #32296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
noisysocks
added
[Feature] Widgets Screen
|
Size Change: -17 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
|
Going to split this up into smaller pieces. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves upon #32176 and fixes #32281.
Contains a few changes intended to make the Gutenberg plugin compatible with both versions of WordPress which support widgets (5.8) and versions that don't (5.7).
wp-admin/theme.php?page=gutenberg-widgetsif core uses the widgets editor inwp-admin/widgets.php.trunk.How has this been tested?
With an environment that has both
wordpress-develop-gitandgutenbergcloned and running together:5.7branch inwordpress-develop-git.theme.php?page=gutenberg-widgets.masterbranch inwordpress-develop-git.widgets.php.widgets.php.Note: There is a PHP warning caused by registering
core/legacy-widgettwice when running the Gutenberg plugin against latest coretrunk. This will be fixed once@wordpress/block-libraryis published to npm with the changes in this PR and included in core. You can verify this by copyingpackages/block-library/src/legacy-widget/index.phpin Gutenberg toblocks/legacy-widget.phpin core.