Fix errors caused by adding widgets to WordPress core #32176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
noisysocks
force-pushed
the
fix/5.8-widgets-compatibility
branch
from
3635457 to
724ab4c
Compare
noisysocks
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
noisysocks
force-pushed
the
fix/5.8-widgets-compatibility
branch
from
749810d to
9b6dd58
Compare
kevin940726
force-pushed
the
fix/5.8-widgets-compatibility
branch
from
96b3ae7 to
7805bd8
Compare
…Core. (#32183) * Adapt the Gutenberg plugin's code to work with FSE infrastructure in Core * small changes coming from the merge ticket Co-authored-by: André <[email protected]>
ellatrix
force-pushed
the
fix/5.8-widgets-compatibility
branch
from
4a05a03 to
5c4382b
Compare
ockham
reviewed
May 25, 2021
Comment on lines
+68
to
+70
| $this->markTestSkipped( | ||
| 'The test is failing with latest WordPress core.' | ||
| ); |
There was a problem hiding this comment.
We've marked this test as skipped since it was consistently failing. We think that it's because Gutenberg is re-registering the widgets controller (which is now also in Core) for the corresponding REST API routes, thus causing conflicts, but weren't exactly sure about the best way to fix (that would also retain functionality). @noisysocks @draganescu @talldan et al -- could y'all look into this and file a PR to fix the tests, and remove the markTestSkipped lines? 🙏
ockham
reviewed
May 25, 2021
Comment on lines
+398
to
+402
|
|
||
| $this->markTestSkipped( | ||
| 'The test is failing with latest WordPress core.' | ||
| ); | ||
|
|
There was a problem hiding this comment.
ockham
reviewed
May 25, 2021
Comment on lines
+236
to
+239
| $this->markTestSkipped( | ||
| 'The test is failing with latest WordPress core.' | ||
| ); | ||
|
|
There was a problem hiding this comment.
ockham
reviewed
May 25, 2021
Comment on lines
+647
to
+650
| $this->markTestSkipped( | ||
| 'The test is failing with latest WordPress core.' | ||
| ); | ||
|
|
There was a problem hiding this comment.
|
E2e tests are still failing. The failure is: Screenshot from failure artifacts:
That aside, there are a few other errors: (Error msg repeated 5 times) (Error msg repeated ~10 times) |
ockham
approved these changes
May 25, 2021
There was a problem hiding this comment.
LGTM. We know that there's more work to do (to fix the e2e test failure, and to re-enable these widgets controller unit tests), but this PR is a big step in the right direction, as it cuts down the number of failures significantly.
ellatrix
approved these changes
May 25, 2021
youknowriad
added a commit
that referenced
this pull request
May 26, 2021
…#32176) Including the Widgets editor and template mode. Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: André <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Bernie Reiter <[email protected]> Co-authored-by: Ella van Durpe <[email protected]>
|
Cherry-picked into 10.7 release branch. |
4 tasks
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added a commit
that referenced
this pull request
May 31, 2021
…#32176) Including the Widgets editor and template mode. Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: André <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Bernie Reiter <[email protected]> Co-authored-by: Ella van Durpe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors in the Gutenberg plugin caused by the merge of WordPress/wordpress-develop#1293 and WordPress/wordpress-develop#1284.