Workflows: Fix "Stable tag:" readme.txt field in SVN upload #31897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
Gutenberg Plugin
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
ocean90
approved these changes
May 17, 2021
ntsekouras
pushed a commit
that referenced
this pull request
May 20, 2021
Our SVN plugin upload workflow currently clears the `Stable tag:` field in `readme.txt` when preparing the plugin for upload to SVN. This commit fixes the issue by using `awk` rather than `grep` + a RegEx. Another advantage of the new solution is that it can be easily tested on a non-bash shell (e.g. on macOS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31357.
Our SVN plugin upload workflow currently clears the
Stable tag:field inreadme.txtwhen preparing the plugin for upload to SVN.This PR fixes the issue by using
awkrather thangrep+ a RegEx. Another advantage of the new solution is that it can be easily tested on a non-bash shell (e.g. on macOS).How has this been tested?
I cherry-picked the commit to my fork's
trunkandrelease/10.6branches, and created a (fake) 10.6.1 release there. This triggered the relevant workflow -- see screenshots below.Screenshots
Note the value of the
STABLE_TAGenv var:Before
(from https://github.com/WordPress/gutenberg/runs/2239867087?check_suite_focus=true, via #31357 (comment))
After
(from https://github.com/ockham/gutenberg/runs/2602181521?check_suite_focus=true)
Types of changes
Bug fix.