SVN Upload Workflow: Stable tag: isn't set in readme.txt

[ockham]

While releasing GB 10.5.1 and 10.5.2 today, @youknowriad noticed that the Stable tag: field isn't being set in the plugin's readme.txt in the WP.org plugin repo (SVN) anymore.

I looked at previous versions and found that the last version that had it set was 10.2.1 -- starting from 10.3.0, the Stable tag: was empty.

Fortunately, this seems rather low-impact, as WP.org apparently falls back to what it determines to be the latest version (probably based on release date, or version comparisons -- both of which work for GB, as per our current release procedure).

For reference, this is the code that's supposed to set the Stable tag::

gutenberg/.github/workflows/upload-release-to-plugin-repo.yml

Lines 149 to 154 in f3c599d

	- name: Update the plugin's stable version
	working-directory: ./trunk
	run: |
	sed -i "s/Stable tag: ${STABLE_VERSION_REGEX}/Stable tag: ${VERSION}/g" ./readme.txt
	svn commit -m "Releasing version $VERSION" \
	--no-auth-cache --non-interactive --username "$SVN_USERNAME" --password "$SVN_PASSWORD"

[ockham]

This seems to coincide with #28138 (or maybe #30212).

[ockham]

Upon closer inspection of the SVN log (note the Committing version x.y.z vs Releasing version x.y.z commit messages, and to which steps of the workflow they relate), I think it's probably this step that didn't work:

gutenberg/.github/workflows/upload-release-to-plugin-repo.yml

Lines 123 to 127 in f3c599d

	- name: Replace the stable tag placeholder with the existing stable tag on the SVN repository
	env:
	STABLE_TAG_PLACEHOLDER: 'Stable tag: V\.V\.V'
	STABLE_TAG: 'Stable tag: ${{ steps.get_previous_stable_version.outputs.stable_version }}'
	run: sed -i "s/${STABLE_TAG_PLACEHOLDER}/${STABLE_TAG}/g" ./trunk/readme.txt

[ockham]

Yeah, I think I've tracked it down to here: https://github.com/WordPress/gutenberg/runs/2239867087?check_suite_focus=true

[ockham]

Seems like steps.get_previous_stable_version.outputs.stable_version was empty 🤔

gutenberg/.github/workflows/upload-release-to-plugin-repo.yml

Lines 105 to 109 in cec7a68

	- name: Get previous stable version
	id: get_previous_stable_version
	env:
	STABLE_TAG_REGEX: 'Stable tag: \K${{ env.STABLE_VERSION_REGEX }}'
	run: echo ::set-output name=stable_version::$(grep -oP "${STABLE_TAG_REGEX}" ./trunk/readme.txt)

Could it be an issue with escaping? 🤔

[ocean90]

This needs to get fixed since currently the plugin directory simply falls back to trunk. See https://api.wordpress.org/plugins/info/1.0/gutenberg.json?fields=stable_tag,short_description where stable_tag is set to trunk.

This prevents using the dev and stable projects for translations as currently only dev is used.

[ockham]

I'll look into fixing this 👍