Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Workflow: Allow triggering manually #28138

Merged
merged 42 commits into from
Mar 18, 2021

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Jan 12, 2021

Description

Allow manual triggering of the workflow to create a new release, per this discussion.

The end goal is for the release manager to run the entire release process from GitHub, and to minimize manual interaction.

  • ✋ Release manager starts release process manually.
  • 🤖 GitHub workflow bumps version numbers in plugin files, builds Gutenberg plugin, creates release draft, and prefills it with release notes based on changelog script output.
  • ✋ Release manager edits release draft, and eventually publishes it. This creates the tag.
  • 🤖 (Other) GitHub workflow tags prepends release notes to changelog.txt, uploads Gutenberg plugin and updated changelog.txt to WP.org plugin repo.

Functionally, this is as close as possible to the previous workflow. The major difference is that changelog.txt is only updated after tagging. This is a result of using the GitHub release draft UI to edit and revise release notes. It's not possible to include the result of those changes before tagging.

Demo

https://youtu.be/TnSgJd3zpJY

How has this been tested?

See here for an example release created by this action: https://github.com/ockham/gutenberg/releases/tag/v10.2.0

Corresponding workflow run: https://github.com/ockham/gutenberg/actions/runs/654286491

Or use the following instructions to test for yourself:

  • Make sure you have your own fork of the Gutenberg repo, and that you've added it locally as a remote (E.g. git remote add ockham git@github.com:ockham/gutenberg.git if your GH username is ockham 🙂 ).
  • Check out this PR's branch, and push the contents to your fork's trunk branch (you can reset later):
git push ockham update/trigger-release-workflow-manually:trunk --force
  • Do the same for the current release branch, e.g.
git push ockham update/trigger-release-workflow-manually:release/10.2 --force
  • Go to the 'Actions' tab of your fork's GH page (e.g. https://github.com/ockham/gutenberg/actions).
  • In the left sidebar (list of available actions), locate the action whose description reads "Build Gutenberg and upload to Draft Release", and click on it.
  • Locate the blue "This workflow has a workflow_dispatch event trigger." header, and click the "Run workflow" button next to it.
  • Keep the trunk branch as the base branch, and specify either stable or rc to release create a stable or release candidate version of the plugin.
  • It should take less than 5 minutes to build the plugin zip. You can watch that page as the action progresses.
  • Eventually, a release draft will be created, and the plugin zip will be attached. You'll find it under 'Releases' (e.g. https://github.com/ockham/gutenberg/releases)
  • Download the release.
  • Verify that the plugin version has indeed been updated (in gutenberg.php, package.json, etc), and that the Changelog contains the release notes for the release.
  • Verify that the newly created tag for the release also has the version bump, especially when creating an RC!
  • Publish the release, and verify that the release notes are correctly used to update changelog.txt on both trunk, and the release branch.

(I've used my Gutenberg fork as an example, you can see the relevant action and release drafts from previous runs there.)

Follow-up:

  • Update docs
  • Remove old release script
  • Modify svn logic to allow uploading point releases for previous version series. (Use the correct changelog, and to only set the "Stable Version" thing if we are updating the stable version.)

Sorry, something went wrong.

@ockham ockham added the [Type] Build Tooling Issues or PRs related to build tooling label Jan 12, 2021
@ockham ockham self-assigned this Jan 12, 2021
@github-actions
Copy link

github-actions bot commented Jan 12, 2021

Size Change: +3.58 kB (0%)

Total Size: 1.4 MB

Filename Size Change
build/annotations/index.js 3.78 kB +1 B (0%)
build/blob/index.js 665 B +1 B (0%)
build/block-directory/index.js 8.63 kB -4 B (0%)
build/block-editor/index.js 126 kB +1.22 kB (+1%)
build/block-editor/style-rtl.css 12.4 kB +79 B (+1%)
build/block-editor/style.css 12.4 kB +80 B (+1%)
build/block-library/blocks/cover/editor-rtl.css 605 B +6 B (+1%)
build/block-library/blocks/cover/editor.css 605 B +6 B (+1%)
build/block-library/blocks/freeform/editor-rtl.css 2.46 kB +7 B (0%)
build/block-library/blocks/freeform/editor.css 2.46 kB +7 B (0%)
build/block-library/blocks/gallery/editor-rtl.css 704 B +15 B (+2%)
build/block-library/blocks/gallery/editor.css 705 B +15 B (+2%)
build/block-library/blocks/group/editor-rtl.css 160 B -158 B (-50%) 🏆
build/block-library/blocks/group/editor.css 160 B -157 B (-50%) 🏆
build/block-library/blocks/navigation-link/editor-rtl.css 626 B +6 B (+1%)
build/block-library/blocks/navigation-link/editor.css 627 B +6 B (+1%)
build/block-library/blocks/navigation-link/style-rtl.css 680 B +9 B (+1%)
build/block-library/blocks/navigation-link/style.css 678 B +10 B (+1%)
build/block-library/blocks/navigation/editor-rtl.css 1.11 kB +24 B (+2%)
build/block-library/blocks/navigation/editor.css 1.11 kB +24 B (+2%)
build/block-library/blocks/page-list/editor-rtl.css 170 B -45 B (-21%) 🎉
build/block-library/blocks/page-list/editor.css 170 B -45 B (-21%) 🎉
build/block-library/blocks/page-list/style-rtl.css 537 B +10 B (+2%)
build/block-library/blocks/page-list/style.css 536 B +10 B (+2%)
build/block-library/blocks/query/editor-rtl.css 820 B +6 B (+1%)
build/block-library/blocks/query/editor.css 819 B +7 B (+1%)
build/block-library/blocks/shortcode/editor-rtl.css 512 B +8 B (+2%)
build/block-library/blocks/shortcode/editor.css 512 B +8 B (+2%)
build/block-library/blocks/social-links/editor-rtl.css 776 B +7 B (+1%)
build/block-library/blocks/social-links/editor.css 776 B +7 B (+1%)
build/block-library/blocks/social-links/style-rtl.css 1.32 kB +8 B (+1%)
build/block-library/blocks/social-links/style.css 1.33 kB +8 B (+1%)
build/block-library/blocks/template-part/editor-rtl.css 552 B -5 B (-1%)
build/block-library/blocks/template-part/editor.css 551 B -5 B (-1%)
build/block-library/blocks/verse/editor-rtl.css 50 B -12 B (-19%) 👏
build/block-library/blocks/verse/editor.css 50 B -12 B (-19%) 👏
build/block-library/editor-rtl.css 9.48 kB -98 B (-1%)
build/block-library/editor.css 9.48 kB -98 B (-1%)
build/block-library/index.js 147 kB +406 B (0%)
build/block-library/style-rtl.css 8.88 kB +31 B (0%)
build/block-library/style.css 8.88 kB +31 B (0%)
build/blocks/index.js 48.3 kB +21 B (0%)
build/components/index.js 284 kB +462 B (0%)
build/components/style-rtl.css 16.2 kB +39 B (0%)
build/components/style.css 16.2 kB +42 B (0%)
build/compose/index.js 11.2 kB +90 B (+1%)
build/core-data/index.js 16.7 kB +3 B (0%)
build/customize-widgets/index.js 3.95 kB -1 B (0%)
build/data-controls/index.js 830 B +1 B (0%)
build/data/index.js 8.87 kB -2 B (0%)
build/date/index.js 31.8 kB +1 B (0%)
build/deprecated/index.js 768 B -1 B (0%)
build/dom/index.js 4.96 kB +33 B (+1%)
build/edit-navigation/index.js 11.9 kB +18 B (0%)
build/edit-navigation/style-rtl.css 1.31 kB +2 B (0%)
build/edit-navigation/style.css 1.31 kB +3 B (0%)
build/edit-post/index.js 307 kB +712 B (0%)
build/edit-post/style-rtl.css 7.12 kB +295 B (+4%)
build/edit-post/style.css 7.11 kB +289 B (+4%)
build/edit-site/index.js 27.2 kB -4 B (0%)
build/edit-site/style-rtl.css 4.55 kB +66 B (+1%)
build/edit-site/style.css 4.55 kB +66 B (+1%)
build/edit-widgets/index.js 20.2 kB +31 B (0%)
build/editor/index.js 41.9 kB +79 B (0%)
build/editor/style-rtl.css 3.9 kB +8 B (0%)
build/editor/style.css 3.9 kB +8 B (0%)
build/element/index.js 4.61 kB +1 B (0%)
build/format-library/index.js 6.75 kB -3 B (0%)
build/keyboard-shortcuts/index.js 2.53 kB +4 B (0%)
build/media-utils/index.js 5.34 kB +1 B (0%)
build/notices/index.js 1.85 kB +3 B (0%)
build/nux/index.js 3.41 kB -1 B (0%)
build/primitives/index.js 1.42 kB +1 B (0%)
build/react-i18n/index.js 1.46 kB +2 B (0%)
build/redux-routine/index.js 2.84 kB +1 B (0%)
build/rich-text/index.js 13.3 kB -114 B (-1%)
build/shortcode/index.js 1.7 kB -1 B (0%)
build/url/index.js 3.02 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/block-directory/style-rtl.css 1 kB 0 B
build/block-directory/style.css 1.01 kB 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 112 B 0 B
build/block-library/blocks/audio/style.css 112 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/button/style-rtl.css 479 B 0 B
build/block-library/blocks/button/style.css 479 B 0 B
build/block-library/blocks/buttons/editor-rtl.css 315 B 0 B
build/block-library/blocks/buttons/editor.css 315 B 0 B
build/block-library/blocks/buttons/style-rtl.css 364 B 0 B
build/block-library/blocks/buttons/style.css 363 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 421 B 0 B
build/block-library/blocks/columns/style.css 421 B 0 B
build/block-library/blocks/cover/style-rtl.css 1.24 kB 0 B
build/block-library/blocks/cover/style.css 1.24 kB 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 401 B 0 B
build/block-library/blocks/embed/style.css 400 B 0 B
build/block-library/blocks/file/editor-rtl.css 199 B 0 B
build/block-library/blocks/file/editor.css 198 B 0 B
build/block-library/blocks/file/style-rtl.css 248 B 0 B
build/block-library/blocks/file/style.css 248 B 0 B
build/block-library/blocks/gallery/style-rtl.css 1.11 kB 0 B
build/block-library/blocks/gallery/style.css 1.1 kB 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 476 B 0 B
build/block-library/blocks/image/style.css 478 B 0 B
build/block-library/blocks/latest-comments/editor-rtl.css 159 B 0 B
build/block-library/blocks/latest-comments/editor.css 158 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 269 B 0 B
build/block-library/blocks/latest-comments/style.css 269 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/list/editor-rtl.css 65 B 0 B
build/block-library/blocks/list/editor.css 65 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 191 B 0 B
build/block-library/blocks/media-text/editor.css 191 B 0 B
build/block-library/blocks/media-text/style-rtl.css 535 B 0 B
build/block-library/blocks/media-text/style.css 532 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/navigation/style-rtl.css 204 B 0 B
build/block-library/blocks/navigation/style.css 205 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B 0 B
build/block-library/blocks/paragraph/editor.css 157 B 0 B
build/block-library/blocks/paragraph/style-rtl.css 247 B 0 B
build/block-library/blocks/paragraph/style.css 248 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 250 B 0 B
build/block-library/blocks/post-comments-form/style.css 250 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 100 B 0 B
build/block-library/blocks/post-featured-image/style.css 100 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 63 B 0 B
build/block-library/blocks/preformatted/style.css 63 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 318 B 0 B
build/block-library/blocks/pullquote/style.css 318 B 0 B
build/block-library/blocks/query-loop/editor-rtl.css 90 B 0 B
build/block-library/blocks/query-loop/editor.css 89 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query-title/editor-rtl.css 86 B 0 B
build/block-library/blocks/query-title/editor.css 86 B 0 B
build/block-library/blocks/quote/editor-rtl.css 61 B 0 B
build/block-library/blocks/quote/editor.css 61 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/search/editor-rtl.css 165 B 0 B
build/block-library/blocks/search/editor.css 165 B 0 B
build/block-library/blocks/search/style-rtl.css 342 B 0 B
build/block-library/blocks/search/style.css 344 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 236 B 0 B
build/block-library/blocks/separator/style.css 236 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 201 B 0 B
build/block-library/blocks/site-logo/editor.css 201 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 115 B 0 B
build/block-library/blocks/site-logo/style.css 115 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/spacer/editor-rtl.css 317 B 0 B
build/block-library/blocks/spacer/editor.css 317 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/table/editor-rtl.css 478 B 0 B
build/block-library/blocks/table/editor.css 478 B 0 B
build/block-library/blocks/table/style-rtl.css 402 B 0 B
build/block-library/blocks/table/style.css 402 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/term-description/editor-rtl.css 90 B 0 B
build/block-library/blocks/term-description/editor.css 90 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 504 B 0 B
build/block-library/blocks/video/editor.css 503 B 0 B
build/block-library/blocks/video/style-rtl.css 187 B 0 B
build/block-library/blocks/video/style.css 187 B 0 B
build/block-library/common-rtl.css 1.1 kB 0 B
build/block-library/common.css 1.1 kB 0 B
build/block-library/theme-rtl.css 700 B 0 B
build/block-library/theme.css 701 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/customize-widgets/style-rtl.css 168 B 0 B
build/customize-widgets/style.css 168 B 0 B
build/dom-ready/index.js 576 B 0 B
build/edit-widgets/style-rtl.css 3.2 kB 0 B
build/edit-widgets/style.css 3.2 kB 0 B
build/editor/editor-styles-rtl.css 347 B 0 B
build/editor/editor-styles.css 347 B 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/hooks/index.js 2.28 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 4.01 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keycodes/index.js 1.95 kB 0 B
build/list-reusable-blocks/index.js 3.14 kB 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/nux/style-rtl.css 731 B 0 B
build/nux/style.css 727 B 0 B
build/plugins/index.js 2.89 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/reusable-blocks/index.js 3.78 kB 0 B
build/reusable-blocks/style-rtl.css 225 B 0 B
build/reusable-blocks/style.css 225 B 0 B
build/server-side-render/index.js 2.58 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@ockham ockham force-pushed the update/trigger-release-workflow-manually branch from 579907d to ab4ce92 Compare January 26, 2021 14:17
@ockham ockham force-pushed the update/trigger-release-workflow-manually branch from ab4ce92 to 101b51a Compare February 4, 2021 19:44
@ockham ockham force-pushed the update/trigger-release-workflow-manually branch from 101b51a to fdd6683 Compare February 12, 2021 18:51
ockham added a commit that referenced this pull request Feb 17, 2021
…8424)

The Changelog generator script, `bin/plugin/commands/changelog.js`, currently doesn't support patch releases: It's only possible to generate a Changelog for a given milestone (which are per-minor-release, i.e. per-release-branch), but not on a more fine-grained basis. If the Changelog script is run for a patch release, the generated Changelog includes everything from the `.0` stable release from that series up to the patch release.

This PR adds an `--unreleased` option to the Changelog script that makes it look up the latest release in the series, and only includes issues that were modified after that release was published. This will allow us to use the script to generate the Changelog for patch releases (or at least a baseline -- see 'Discussion' for a caveat).

This will come in handy as we automate more and more parts of the build process -- especially to auto-generate a Changelog for patch releases, and to pre-populate the corresponding release notes. (Cf. #28138.)
@ockham ockham force-pushed the update/trigger-release-workflow-manually branch 2 times, most recently from a22c475 to a7a3730 Compare February 19, 2021 19:38
ockham added a commit that referenced this pull request Feb 25, 2021
There's one functional change to the release GH workflow included in this PR: Rather than publishing the release right away, only create the draft, and let a human publish it.

The reason for this is twofold:
- The SVN upload action didn't trigger when the release was published. This is because [GH workflows don't trigger other GH workflows](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token) (to avoid recursions). (The workaround was to set the release to pre-release status, and then back.)
- This aligns better with the changes planned in #28138 anyway (where we'll remove the local build script altogether; instead, editing the release draft will be the opportunity for the release manager to actually edit the auto-generated changelog before publishing).

Changes to `release.md` thus include:
- A description of the GH-side steps:
  - Locate the release draft, edit and publish it.
  - The SVN upload action needing approval.
- Commit access to SVN no longer needed. Instead, a member of the `gutenberg-core` team needs to approve the upload.
- ~Two days~ -> One week between RC and stable release.

Finally, instructions in the `release.js` script are updated accordingly. (Keep in mind that that script is slated for removal once #28138 lands).
@ockham ockham force-pushed the update/trigger-release-workflow-manually branch from 01f7063 to b152390 Compare February 25, 2021 19:37
Base automatically changed from master to trunk March 1, 2021 15:45
@ockham ockham force-pushed the update/trigger-release-workflow-manually branch 3 times, most recently from d025b6d to b84b85f Compare March 8, 2021 21:50
@ockham ockham force-pushed the update/trigger-release-workflow-manually branch from e6ecf79 to d500373 Compare March 12, 2021 18:50
@ockham
Copy link
Contributor Author

ockham commented Mar 13, 2021

Okay, I think this is about ready for review. I've limited this to only work if the trunk branch is selected from the workflow_dispatch dropdown for now (which is all that's needed for feature parity with what the local script does) -- any other branch just won't trigger the version bump and release draft creation.

I still need to update the PR description a bit, and maybe provide a better gif or video to demo it. But that's for next week.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the release script and update the docs here or as a follow-up?

@ockham
Copy link
Contributor Author

ockham commented Mar 16, 2021

I noticed on the changelog commit that there are 3 empty lines added when the changelog is updated, so we end up with 6 empty lines between versions.

Ah, good spot! I'll take care of that.

@ockham
Copy link
Contributor Author

ockham commented Mar 16, 2021

Should we remove the release script and update the docs here or as a follow-up?

Might be worth doing here 👍

@swissspidy
Copy link
Member

@ockham curious, how have you tested the svn part? So far I am using a dummy repo on SourceForge (working on automation for a plugin as well), but perhaps there's a better way.

@ockham
Copy link
Contributor Author

ockham commented Mar 16, 2021

@ockham curious, how have you tested the svn part? So far I am using a dummy repo on SourceForge (working on automation for a plugin as well), but perhaps there's a better way.

I'm afraid I haven't found a better way myself yet -- I'm using a dummy repo that I created at https://riouxsvn.com (thanks to a tip from @jorgefilipecosta).

@ockham
Copy link
Contributor Author

ockham commented Mar 18, 2021

I noticed on the changelog commit that there are 3 empty lines added when the changelog is updated, so we end up with 6 empty lines between versions.

Ah, good spot! I'll take care of that.

Addressed in fc79221.

@ockham ockham requested review from nerrad and ntwb as code owners March 18, 2021 18:13
@ockham
Copy link
Contributor Author

ockham commented Mar 18, 2021

Should we remove the release script and update the docs here or as a follow-up?

Might be worth doing here

Done in the past couple of commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants