Navigation Editor: Clear 'stub' navigation post edits on save #31735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
7 tasks
|
Size Change: +14 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
getdave
approved these changes
May 12, 2021
There was a problem hiding this comment.
Screen.Capture.on.2021-05-12.at.15-36-33.mov
Nice work sleuthing this and finding a solution!
Tested and now works as expected. No more "you have unsaved changes" warning when trying to go to another page following saving and also Save button remains disabled when I have saved and not made further changes 👍
I wonder whether it would be useful to add a quick e2e test to cover this scenario? I'll leave that up to you to consider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Navigation Editor uses the 'stub' post entity on runtime to provide a convenient way of editing navigation items using a regular post editor.
While this works as expected. We can't save this runtime entity using the regular
saveEntityRecordaction when saving the menu, and the state stays "dirty." Latter causes an issue when we want to warn users about unsaved changes (#31197).This PR tries to solve the issue by clearing navigation post edits when a menu is successfully saved.
How has this been tested?
Make sure store unit tests are passing:
Screenshots
CleanShot.2021-05-12.at.10.11.46.mp4
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).