Navigation Screen: warn the user about unsaved changes #31197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Feature] Navigation Screen
[Type] Enhancement
|
Size Change: +2.96 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
requested changes
May 4, 2021
There was a problem hiding this comment.
Nice work here. The concept is great but for some reason the dirty detection seems off in the Core Store.
As you can see below, I make changes and click Save and then try to navigate away and it still thinks there are dirty changes.
Screen.Capture.on.2021-05-04.at.12-35-31.mov
Also once this is working, we need to add e2e tests to avoid regressions.
|
Thanks for the review, @getdave I'm aware of this issue but not sure what's the best way to fix it. My best guess is that it happens because we're using AJAX. The same issue affects my other PR #31119 (comment). |
Could you bring it up in open floor of Core Editor chat to see if folks are aware of the Issue? |
|
I did a little more research. I think the state stays "dirty" because of the stub navigation post. See Based on the selector comment, this record - "should only exist on runtime and should never be saved." While this works fine, changes to the record aren't removed from the edited state when saving the menu. I'm not familiar with this part of the code and unsure of the best next step. |
That makes sense. I guess one way would be to simulate the way that saving clears the dirty state. I wonder how |
|
Or I guess it might also be possible to ignore the stub post in the |
I had the same idea to check edited records for the Looking at the |
7 tasks
|
I was able to resolve the "dirty" state issue via PR #31735. |
Mamaduka
force-pushed
the
add/nav-screen-prompt-to-save
branch
from
eb213bc to
dcb69c8
Compare
|
✅ Approved. Let's rebase here and I'll happily re-test for you. |
Mamaduka
force-pushed
the
add/nav-screen-prompt-to-save
branch
from
dcb69c8 to
8558173
Compare
|
Rebased branch, and it's ready for re-testing. |
|
@getdave I added some basic e2e tests for warning dialog as we discussed. |
getdave
approved these changes
May 13, 2021
|
Great work here @Mamaduka. Everything is working really nicely and the addition of e2e tests should avoid any further issues with dirty state and saving. |
|
Associated issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds warning for users that they will lose unsaved data when navigating away.
See #30322.
Closes #30423.
How has this been tested?
Screenshots
CleanShot.2021-04-26.at.17.39.44.mp4
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).