Fix: Allow post comment button to inherit button & global styles automatically #31338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Feature] Themes
|
Size Change: -321 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
What a rollercoaster:
Really nice work, though! This is before:
This is after:
From just testing this corner of the flow, it seems clear that showing Also, the placeholder state for the comment form feels rather lacking, with just the text prompt. It could/should look just like the frontend, no reason not to. However both of those appear to be existing issues entirely unrelated to this PR, but thought were just worth mentioning. Just on its own, this PR feels like a vast improvement. The code also looks good to me, and I'm happy to give a ✅ — but because it's touching PHP corners of FSE that I haven't trodden that well, I'd love one small sanity check, for example by @ntsekouras if he has time. |
|
Thank you for checking this!
Yeah... Instead of initially creating the branch from
Agreed, the block's placeholder definitely needs to be improved in a separate PR 👍 |
ntsekouras
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Thanks Ari!
What a rollercoaster:
😁
I think this is okay for now (and definitely an improvement) but the root issue remains the implementation of this block. Related issue: #24221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inside a
theme.jsonfile add this:{ "styles": { "core/button": { "border": { "radius": "7px" }, "color": { "background": "#000", "text": "#fff" } } } }You'll see that buttons become black, with white text, and a 7px border-radius. But not the comment-form button.. We've copied the button CSS directly there and it overrides any CSS from global styles.
This PR cleans up the CSS to allow inheriting styles from the button directly, and also allows global styles to be applied properly.
How has this been tested?
Tested in a block theme with and without the
theme.jsontweak. In both cases the comment-form is the same as all other buttons on the site.Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).