Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Design of Post Comment button in single post #281

Closed
kafleg opened this issue Dec 8, 2021 · 7 comments
Closed

Design of Post Comment button in single post #281

kafleg opened this issue Dec 8, 2021 · 7 comments
Labels
[Type] Bug Something isn't working

Comments

@kafleg
Copy link
Member

kafleg commented Dec 8, 2021

Installed beta 2 version of 5.9 and preview the single post page. The design of the button is not good.
Do we have a design idea for that button?

  • Install WordPress 5.9 beta 2
  • Preview the Hello World post
  • Scroll down to the comment section.
    image

Also, logout the site and see the comment section on the front page.
image

@kafleg
Copy link
Member Author

kafleg commented Dec 8, 2021

@bijayyadav was interested to contribute to the theme. You can check and follow up.

@bijayyadav
Copy link

I would like to fix and commit, is there any recommendation for the design? If I get the design, I can fix and commit.

@kjellr kjellr added the [Type] Bug Something isn't working label Dec 8, 2021
@kjellr
Copy link
Collaborator

kjellr commented Dec 8, 2021

This should not be fixed in the theme. It looks like there's a mismatch between a change in Core and something in the Gutenberg plugin. In Gutenberg, the button carries a wp-block-button__link class, which lets it inherit the default button appearance, but this is missing in core.

cc @noisysocks can you help pinpoint what's missing here?

Gutenberg Core
Screen Shot 2021-12-08 at 7 50 24 AMScreen Shot 2021-12-08 at 7 50 39 AM Screen Shot 2021-12-08 at 7 49 52 AMScreen Shot 2021-12-08 at 7 50 07 AM

@noisysocks
Copy link
Member

noisysocks commented Dec 9, 2021

It looks like this was fixed in WordPress/gutenberg#31338 for the Post Comments Form block, but the Post Comments Form block is not included in WP 5.9. Instead, we include Post Comments block which has a form in it. I think therefore we'll need to make a similar change to WordPress/gutenberg#31338 but for the Post Comments block.

@aristath: Do you think you could open a Gutenberg PR for that and put the backport label on it?

@aristath
Copy link
Member

aristath commented Dec 9, 2021

PR in WordPress/gutenberg#37245 👍

@kjellr
Copy link
Collaborator

kjellr commented Dec 9, 2021

Thanks for the quick investigation and fix!

@kafleg
Copy link
Member Author

kafleg commented Dec 13, 2021

Marking this ticket as closed. The issue is fixed. We can reopen later if necessary.

@kafleg kafleg closed this as completed Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants