-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Ensure that uncategorized block types are properly handled #30125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
fix/uncategorized-block-types
branch
from
March 23, 2021 07:46
0c3c653
to
0319395
Compare
gziolo
added
[Type] Regression
Related to a regression in the latest release
[Package] Block editor
/packages/block-editor
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
labels
Mar 23, 2021
ntsekouras
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Grzegorz!
gziolo
referenced
this pull request
Mar 23, 2021
#28036) * Make widget-area a special block to show cateogrization in the inserter * Fix test * Remove outdated childBlocks check in the inserter * Add test for the widgets screen * Remove unused ChildBlocks component
Size Change: +1 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
gziolo
added
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Mar 23, 2021
It looks like the same issue exists in WordPress 5.7:
@peterwilsoncc, it would be a good idea to include it in WordPress 5.7.1. |
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
noisysocks
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Apr 6, 2021
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Package] Block editor
/packages/block-editor
[Type] Regression
Related to a regression in the latest release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raised by @mtias in #30089 (comment):
This PR fixes the issue. It turns out this bug prevented also uncategorized blocks to show in the inserter! It should work properly now.
How has this been tested?
Manually in the block editor by opening the inserter.
Screenshots
Before
After
Types of changes
Regression introduced in #28036.
Checklist: