[Widgets screen] Fix categorization not showing in the global inserter #28036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Widgets Screen
|
Size Change: +1.11 kB (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
kevin940726
requested review from
adamziel,
draganescu,
ellatrix,
noisysocks,
talldan and
tellthemachines
as code owners
|
@kevin940726 Before reviewing, I'd like to have some understanding of what the cause of this is. Why does this problem happen with the widget area block and not other blocks? |
|
@talldan Sure thing! Sorry I didn't make it clear in the description. It's because |
|
@kevin940726 The curious thing is that I don't see the same issue with other blocks like Group, Cover that are container blocks. Looking at the code it seems to be because another block has its That block is the legacy widget: gutenberg/packages/edit-widgets/src/blocks/legacy-widget/block.json Lines 29 to 31 in 6b8bf91 Legacy widget setting widget area as its parent shouldn't mean it's exclusive to the widget area, there can still be other blocks as children. I remember #23231 changed how that works. My conclusion is that this |
|
Ohh I didn't know that! I'll have to take a deeper look into this later. |
|
Removing this check seems to have no effect other than fixing the widgets editor. What should I test? With blocks installed via plugins the categories and collections displayed just fine. |
Yeah, seems like we can safely remove it? I can add some e2e tests to both the post editor and the widgets editor. |
kevin940726
force-pushed
the
update/fix-categorization-in-widgets-screen-inserter
branch
from
90c0dba
to
82d25b6
Compare
draganescu
approved these changes
Jan 15, 2021
talldan
reviewed
Jan 18, 2021
packages/block-editor/src/components/inserter/test/block-types-tab.js
Outdated
Show resolved
Hide resolved
talldan
approved these changes
Jan 19, 2021
talldan
deleted the
update/fix-categorization-in-widgets-screen-inserter
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #26159 and #26329.
Removed the now outdated check of
hasChildItems.How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: