Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block editor: fix misplaced rich text inline toolbar #29874

Closed
wants to merge 1 commit into from
Closed

Block editor: fix misplaced rich text inline toolbar #29874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/rich-text/format-toolbar-container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const FormatToolbarContainer = ( { inline, anchorRef } ) => {
focusOnMount={ false }
anchorRef={ anchorRef }
className="block-editor-rich-text__inline-format-toolbar"
__unstableSlotName="block-toolbar"
__unstableSlotName="__unstable-block-inline-toolbar"
>
<FormatToolbar />
</Popover>
Expand Down
1 change: 1 addition & 0 deletions packages/edit-navigation/src/components/header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ export default function Header( {
<SaveButton navigationPost={ navigationPost } />

<Popover.Slot name="block-toolbar" />
<Popover.Slot name="__unstable-block-inline-toolbar" />
</div>
) }
</div>
Expand Down
1 change: 1 addition & 0 deletions packages/edit-post/src/components/visual-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export default function VisualEditor( { styles } ) {
<EditorStyles styles={ styles } />
<VisualEditorGlobalKeyboardShortcuts />
<Popover.Slot name="block-toolbar" />
<Popover.Slot name="__unstable-block-inline-toolbar" />
<div
ref={ mergedRefs }
className="editor-styles-wrapper"
Expand Down
1 change: 1 addition & 0 deletions packages/edit-site/src/components/block-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export default function BlockEditor( { setIsInserterOpen } ) {
</SidebarInspectorFill>
<div className="edit-site-visual-editor" onWheel={ onWheel }>
<Popover.Slot name="block-toolbar" />
<Popover.Slot name="__unstable-block-inline-toolbar" />
<Iframe
style={ resizedCanvasStyles }
headHTML={ window.__editorStyles.html }
Expand Down
1 change: 1 addition & 0 deletions packages/edit-widgets/src/components/widget-areas-block-editor-content/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default function WidgetAreasBlockEditorContent( {
<BlockEditorKeyboardShortcuts />
<Notices />
<Popover.Slot name="block-toolbar" />
<Popover.Slot name="__unstable-block-inline-toolbar" />
<BlockSelectionClearer>
<WritingFlow>
<ObserveTyping>
Expand Down
1 change: 1 addition & 0 deletions storybook/stories/playground/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ function App() {
</div>
<div className="editor-styles-wrapper">
<Popover.Slot name="block-toolbar" />
<Popover.Slot name="__unstable-block-inline-toolbar" />
<BlockEditorKeyboardShortcuts />
<WritingFlow>
<ObserveTyping>
Expand Down