Block editor: fix misplaced rich text inline toolbar #29874
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26114.
Alternative to #28420.
Currently the inline toolbar popover is misplaced and positioned before the block toolbar, which means that you have to tab through the block toolbar to access it. The inline toolbar popover should be positioned after the block toolbar popover so it receives focus before the block toolbar when reverse tabbing from the block.
Both popovers are filled into the same slot and unfortunately it's not possible to set the order from a fill. I added another slot to enforce the order. Ideally, we should have a better API to define the toolbar area for a block editor.
In the GIF below I use Shift+Tab to navigate to the block toolbar and through the buttons to "Bold".
How has this been tested?
Screenshots
Types of changes
Checklist: