Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in git workflow documentation #29324

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Fix typos in git workflow documentation #29324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9fd3df
Added missing space to provide valid HTML.
felixbaumgaertner Feb 24, 2021
5046431
Docs git-workflow: Fixes error in example code.
felixbaumgaertner Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/contributors/git-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ git commit -m "Your Good Commit Message" path/to/FILE
**Step 6**: Push your change up to GitHub. The change will be pushed to your fork of the repository on the GitHub

```bash
git push -u origin upgrade/my-branch
git push -u origin update/my-branch
```

**Step 7**: Go to your forked repository on GitHub -- it will automatically detect the change and give you a link to create a pull request.
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/search/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function render_block_core_search( $attributes ) {
}

$button_markup = sprintf(
'<button type="submit"class="wp-block-search__button ' . $button_classes . '">%s</button>',
'<button type="submit" class="wp-block-search__button ' . $button_classes . '">%s</button>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change was accidentally included. I saw that it's being fixed in another PR so it's probably fine 😄

$button_internal_markup
);
}
Expand Down