Fix typos in git workflow documentation #29324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbaumgaertner
requested review from
ajitbohra and
chrisvanpatten
as code owners
gziolo
reviewed
Feb 25, 2021
| @@ -80,7 +80,7 @@ function render_block_core_search( $attributes ) { | |||
| } | |||
|
|
|||
| $button_markup = sprintf( | |||
| '<button type="submit"class="wp-block-search__button ' . $button_classes . '">%s</button>', | |||
| '<button type="submit" class="wp-block-search__button ' . $button_classes . '">%s</button>', | |||
There was a problem hiding this comment.
It looks like this change was accidentally included. I saw that it's being fixed in another PR so it's probably fine 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an error in the example code. Line 49 mentions 'update' instead of 'upgrade', which should be the same.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: