-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Prepare mobile columns for different units #26095
Conversation
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested with WPiOS on the release branch with iOS 13, iPhone 11 simulator and LGTM!
But I'm not familiar with the code, so I would appreciate if someone else could look into the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works as advertised 👍 .
Btw: I didn't know switching from visual to html was broken on the demo app! Opening a ticket.
* Release script: Update react-native-editor version to 1.39.0 * Release script: Update with changes from 'npm run core preios' * Update changelog * Update CHANGELOG.md * Allow to display columns with different unit, set their width in percentages (#26095) * [RN Mobile] UBE - Inject css on both page visible and page started (#26071) * [RN Mobile] Ube cannot view or interact with the classic block on jetpack sites (#26168) * [RNMobile] Correct where appender condition is placed (#26203) Co-authored-by: Luke Walczak <[email protected]> Co-authored-by: Marko Savic <[email protected]>
* Release script: Update react-native-editor version to 1.39.0 * Release script: Update with changes from 'npm run core preios' * Update changelog * Update CHANGELOG.md * Allow to display columns with different unit, set their width in percentages (#26095) * [RN Mobile] UBE - Inject css on both page visible and page started (#26071) * [RN Mobile] Ube cannot view or interact with the classic block on jetpack sites (#26168) * [RNMobile] Correct where appender condition is placed (#26203) * Release script: Update react-native-editor version to 1.39.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Heading block - Disable full-width/wide alignment (#26308) * Update CHANGELOG.md Co-authored-by: Luke Walczak <[email protected]> Co-authored-by: Marko Savic <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]>
Description
After merging web feature related to introducing
UnitControl
inColumns
block, we observed the crash when saving the post with columns block. That PR is a workaround to avoid the crash:Adjust mobile columns for upcoming web feature.
How has this been tested?
%
in first columns in favour ofrem
(in width and flex-basis as well)Screenshots
Types of changes
Checklist: