-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use UnitControl
instead of RangeControl
for column width"
#26056
Conversation
Size Change: -138 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the revert could potentially affect other merged PRs (after this one) that had to do with And this one is I know because I was the author. There could be many more... 🤔 |
Hello @ntsekouras, could you please checkout on revert branch and test if your functionality works as expected? |
It doesn't break it, but it's definitely not correct, as I'm adding a Also
Can we find a solution for the mobile problems mentioned here: #24711 (comment), instead? |
From my perspective, introducing the |
Any chance we can add those missing features to the mobile platform (possibly at the cost of pushing back a release)? It seems like reverting this PR might otherwise cause us other problems (including block invalidations on websites that have already upgraded to GB 9.1 and where the new version of the Column block has been used). |
I think we can close that PR in favour of temporary workaround. |
Description
This temporarily reverts this PR: #24711 until regressions on web and mobile described in that PR are resolved.