[RNMobile][Monorepo] Merge gutenberg-mobile and gutenberg master #21790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d spacing system (#21111) * Replace "Size" with "Padding" "Size" is somewhat ambiguous. "Padding" is more explicit. * Update padding values to align with core spacing system https://make.wordpress.org/design/2019/10/31/proposal-a-consistent-spacing-system-for-wordpress/ * Revert "Replace "Size" with "Padding"" This reverts commit 25a0ae8. * Update test snapshots * Update test snapshots
* Testing: Fail E2E when page displays warning notices * Testing: Check markup for errors in visitAdminPage * E2E Test Utils: Rename hasPHPError to hasPageError * E2E Test Utils: Handle both plaintext and HTML errors * E2E Test Utils: Refactor hasPageError as getPageError Return error message so it can be used in failure output * E2E Test Utils: Display page error message in failure output
* RNMobile - Layout picker - Update Services emoji * RNMobile - Layout picker - Update Contact emoji
# Conflicts: # gutenberg
Layout picker - Update emoji
…se-PRs New template for release PRs
…it completely on iOS (#2023) * prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS
Align plus icon for the iOS Stepper control
Fixes #20751. Some colors were slightly off. This fixes that.
* RNMobile - Layout Picker - Hide / Show depending on the keyboard's visibility and the screen size * RNMobile - Layout Picker - Show buttons when the keyboard is hidden * RNMobile - Layout picker - Tweak fadeout animation
…keyboard Layout Picker - Keyboard visibility improvements
* Implement Columns/Column block
* Add radio mode to ButtonGroup with aria attributes * Destructure child props * Add tab index for radio buttons * Add keyboard handlers * Remove TODO comment Current behavior is consistent with RadioControl * Add storybook example * Add documentation example * Add StoryShot snapshot * Mention ButtonGroup in RadioControl * Convert to using context instead of cloneElement * Merge refs so forwardRef is still usable with radio group * Refactor to move button props to button component * Refactor for readability * Add comment about default value * Consolidate ref and className * Fix useMemo return value * Update snapshots Reordered props and removed value prop * Partially revert snapshots * Update prop order to match snapshots * Update comments for clarity * Move changes to radio-group and radio * Remove radio button group storybook snapshot * Update ButtonGroup extra props to override role * Implement forwardRef for ButtonGroup * Update snapshot with forwardRef(ButtonGroup) * Update RadioControl to mention RadioGroup * Replace Radio/RadioGroup with Reakit version * Add storybook stories for Radio/RadioGroup * Update Radio/RadioGroup READMEs * Update docs manifest * Add __experimental prefix for Radio/RadioGroup * Pass through disabled state to children * Remove Radio ids from stories * Update snapshots
* Fix reusable block horizontal padding regression. https://github.com/WordPress/gutenberg/pull/21099/files#diff-ee2ed3adbe2578628039530c717a9a93R640 introduced a padding attached to the is-root-container. But a reusable block is also a root container. This PR unsets that. * Fix issue with navigation mode.
ceyhun
requested review from
gziolo
and removed request for
gziolo,
swissspidy,
ntwb,
ajitbohra,
chrisvanpatten,
mmtr,
nerrad,
aduth,
adamsilverstein,
TimothyBJacobs,
ellatrix,
pinarol,
dmsnell,
noahtallen,
mkevins,
etoledom,
jorgefilipecosta and
epiqueras
|
Not sure how but running Edit: nevermind I cleaned up my repo and try again and I'm not seeing this change anymore |
|
haha, I got kinda confused reading this PR, and then I realized that it is not being merged into master. Otherwise I was about to be concerned about the commit history and files changed 🤦♂️ |
|
Sorry about that @noahtallen GitHub auto-requested reviews from everyone 😅 Updated the PR description. |
|
Will now merge with "Allow merge commits" option ON. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a migration effort of gutenberg-mobile to gutenberg repository with git history. More related PRs here: #18508
This PR updates Monorepo branch with latest changes from
gutenberg-mobile/developandgutenberg/masterHow has this been tested?
npm run native start:resetnpm run native testnpm run native bundle:androidnpm run native bundle:iosnpm run native androidnpm run native iosnpm run lintnpm run test-unit:nativeScreenshots
Types of changes
Checklist: