Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorize embeds for easier discovery #2123

Closed
wants to merge 2 commits into from
Closed

Categorize embeds for easier discovery #2123

wants to merge 2 commits into from

Conversation

notnownikki
Copy link
Member

No description provided.

@notnownikki notnownikki mentioned this pull request Aug 1, 2017
Closed
@codecov
Copy link

codecov bot commented Aug 1, 2017 •
edited
Loading

Codecov Report

Merging #2123 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
- Coverage   20.47%   20.43%   -0.04%     
==========================================
  Files         135      135              
  Lines        4245     4243       -2     
  Branches      724      723       -1     
==========================================
- Hits          869      867       -2     
  Misses       2844     2844              
  Partials      532      532
Impacted Files Coverage Δ
blocks/api/categories.js 100% <ø> (ø) ⬆️
blocks/library/embed/index.js 45.97% <0%> (ø) ⬆️
editor/inserter/menu.js 44.62% <100%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3543d4c...f7ab919. Read the comment docs.

mtias
mtias reviewed Aug 1, 2017
View reviewed changes
blocks/api/categories.js
@@ -16,7 +16,12 @@ const categories = [
{ slug: 'formatting', title: __( 'Formatting' ) },
{ slug: 'layout', title: __( 'Layout Blocks' ) },
{ slug: 'widgets', title: __( 'Widgets' ) },
{ slug: 'embed', title: __( 'Embed' ) },
{ slug: 'embed-common', title: __( 'Common' ) },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "common"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not... Although this is just for getting feedback on the UX at this point :)

@mtias mtias added [Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Aug 1, 2017
@notnownikki notnownikki added the Needs Design Feedback Needs general design feedback. label Aug 2, 2017
@anna-harrison
Copy link

Hello again @notnownikki! Any chance you could add a screenshot to this issue... I'm sorry for my lame designer head that is afraid of reading code :-)

@karmatosed
Copy link
Member

I really like this @notnownikki. My only wonder is 'Blogs and Documents' and if there is something better to categorise there. I think it's worth merging though (once the conflict has been resolved).

For reference this is what it looks like:

2017-08-25 at 21 59

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Aug 25, 2017
@notnownikki
Copy link
Member Author

@karmatosed thank you for screenshotting that. @annaephox I'm really sorry for not putting up screenshots, it was exclusionary of me, and I apoligize for making it difficult for you to give feedback. I won't make that mistake again. ❤️

I'll clean up the conflicts on those branches and gif/screenshot next week after the public holiday here :)

@youknowriad
Copy link
Contributor

@notnownikki Any plans for this PR?

@youknowriad youknowriad added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jan 30, 2018
@notnownikki
Copy link
Member Author

Unless anyone thinks there's a pressing need for this, I'm happy to close it. I think adding the extra search keywords to blocks makes them easier to find and I haven't seen anyone wanting to revisit this in a while.

@youknowriad
Copy link
Contributor

Ok, let's close for now and see if it comes up again. Thanks @notnownikki

@youknowriad youknowriad deleted the add/embed-categories branch January 30, 2018 09:15
ceyhun pushed a commit that referenced this pull request Apr 22, 2020
Merge pull request #2123 from wordpress-mobile/feature/layout-picker-…
c5d485a 
…keyboard

Layout Picker - Keyboard visibility improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias mtias left review comments

Assignees
No one assigned
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@notnownikki @anna-harrison @karmatosed @youknowriad @mtias