[Mobile] Cover block upload progress #21197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obile/feature/cover-block-uploads-progress
mkevins
added
[Feature] Media
|
Size Change: 0 B Total Size: 889 kB ℹ️ View Unchanged
|
This was referenced Mar 27, 2020
3 tasks
chipsnyder
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
LGTM
Tested on iOS and Android
I was able to add Images from the device on iOS and Android. Also tested taking images and video and those worked as well.
Note:
I am getting validation errors if I back out during upload and come back in. I'm just mentioning it here to capture it; however, this would probably be handled in another phase. I can add more info here if this is unexpected.
Indeed, this will be handled in another PR. Thanks for testing and reviewing! |
|
Hey, @mkevins 👋 While reviewing I noticed some linting issues, I guess since this is not targeting And a few |
This is so cool! I didn't see this PR enabling it! Cannot wait to try it :D |
…obile/feature/cover-block-uploads-progress
|
Thanks for testing and reviewing! |
mkevins
added a commit
that referenced
this pull request
Apr 9, 2020
* RNMobile - Enable Cover for Production * RNMobile - Cover block - Move gradient background to support overlay functionality * RNMobile - Cover - Image With Focal Point - Check for url changes * Enable upload options for cover block behind dev flag * Use [].prototype.some for media-library-only prop * Use destructuring in renderBackground function * [Mobile] Cover block upload progress (#21197) * Add progress indicator for uploading media * Use default import syntax for Video component * Use optional chaining * Add z-index to upload progress bar * Fix lint Co-authored-by: Gerardo Pacheco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
MediaUploadProgresscomponent to cover block. This adds a progress bar to the block to indicate the progress of ongoing uploads. It also updates theidandurlof the media to the new serveridandurlupon upload completion.Related PRs
gutenberggutenberg-mobile: Enable cover block uploads behind dev flag wordpress-mobile/gutenberg-mobile#2070WordPress-Android: Cover block upload completion processor wordpress-mobile/WordPress-Android#11541WordPress-iOS: [Testing] Enable cover block uploads behind dev flag wordpress-mobile/WordPress-iOS#13769Testing steps
Expected:
https:, notfile:)Screenshots
Additional changes
In order to ensure the progress bar was displayed on top of the media, it was necessary to add a
z-indexto theMediaUploadProgresscomponent'sprogressBarclass: 7f00459.I also simplified a few other areas via optional chaining: 5cd723e.
Checklist: