-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Cover block upload progress #21197
[Mobile] Cover block upload progress #21197
Conversation
…obile/feature/cover-block-uploads-progress
Size Change: 0 B Total Size: 889 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested on iOS and Android
I was able to add Images from the device on iOS and Android. Also tested taking images and video and those worked as well.
Note:
I am getting validation errors if I back out during upload and come back in. I'm just mentioning it here to capture it; however, this would probably be handled in another phase. I can add more info here if this is unexpected.
Indeed, this will be handled in another PR. Thanks for testing and reviewing! |
Hey, @mkevins 👋 While reviewing I noticed some linting issues, I guess since this is not targeting
And a few |
This is so cool! I didn't see this PR enabling it! Cannot wait to try it :D |
…obile/feature/cover-block-uploads-progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing and reviewing! |
* RNMobile - Enable Cover for Production * RNMobile - Cover block - Move gradient background to support overlay functionality * RNMobile - Cover - Image With Focal Point - Check for url changes * Enable upload options for cover block behind dev flag * Use [].prototype.some for media-library-only prop * Use destructuring in renderBackground function * [Mobile] Cover block upload progress (#21197) * Add progress indicator for uploading media * Use default import syntax for Video component * Use optional chaining * Add z-index to upload progress bar * Fix lint Co-authored-by: Gerardo Pacheco <[email protected]>
Description
This PR adds the
MediaUploadProgress
component to cover block. This adds a progress bar to the block to indicate the progress of ongoing uploads. It also updates theid
andurl
of the media to the new serverid
andurl
upon upload completion.Related PRs
gutenberg
gutenberg-mobile
: Enable cover block uploads behind dev flag wordpress-mobile/gutenberg-mobile#2070WordPress-Android
: Cover block upload completion processor wordpress-mobile/WordPress-Android#11541WordPress-iOS
: [Testing] Enable cover block uploads behind dev flag wordpress-mobile/WordPress-iOS#13769Testing steps
Expected:
https:
, notfile:
)Screenshots
Additional changes
In order to ensure the progress bar was displayed on top of the media, it was necessary to add a
z-index
to theMediaUploadProgress
component'sprogressBar
class: 7f00459.I also simplified a few other areas via optional chaining: 5cd723e.
Checklist: