[Mobile] Enable cover block uploads - dev only #21196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/block-library/src/cover/edit.native.js
…k-uploads-dev-only
mkevins
added
[Feature] Media
|
Size Change: 0 B Total Size: 904 kB ℹ️ View Unchanged
|
This was referenced Mar 27, 2020
3 tasks
chipsnyder
approved these changes
Mar 31, 2020
|
LGTM as well! Tested the generated IPA and APK and the options are not shown. Also tested locally and the options show for both OS. ✅ |
mkevins
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten and
ellatrix
as code owners
mkevins
removed request for
mkaz,
youknowriad,
oandregal,
atimmer,
noisysocks,
SergioEstevao,
talldan,
Soean,
gziolo,
swissspidy,
ntwb,
ajitbohra,
chrisvanpatten,
mmtr,
nerrad,
aduth,
adamsilverstein,
TimothyBJacobs,
ellatrix,
pinarol,
noahtallen,
etoledom,
jorgefilipecosta and
epiqueras
* Add progress indicator for uploading media * Use default import syntax for Video component * Use optional chaining * Add z-index to upload progress bar * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables upload options for Cover block behind the
__DEV__flag. This PR onlyenablesthe options. The UI for uploading (progress bar, upload cancellation, failure, etc.) will be implemented in subsequent PRs.Related PRs
gutenberggutenberg-mobile: Enable cover block uploads behind dev flag wordpress-mobile/gutenberg-mobile#2070WordPress-Android: Cover block upload completion processor wordpress-mobile/WordPress-Android#11541WordPress-iOS: [Testing] Enable cover block uploads behind dev flag wordpress-mobile/WordPress-iOS#13769Testing steps
In development mode (with metro running)
Expected:
Media upload options should be available in the bottom sheet.
In production (via peril build)
Peril builds:
Expected:
Media upload options should not be available in the bottom sheet (only the media library option should be visilble).
Screenshots
Checklist: