-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Block: Avoid hiding submenu when adding a link #21035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
requested review from
ajitbohra,
jorgefilipecosta and
Soean
as code owners
March 20, 2020 05:04
talldan
changed the title
Use editor only classname to keep submenus open when inner blocks are…
Nav Block: Avoid hiding submenu when adding a link
Mar 20, 2020
Size Change: +80 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
talldan
added
[Block] Navigation
Affects the Navigation Block
[Type] Bug
An existing feature does not function as intended
labels
Mar 20, 2020
draganescu
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy, I tested this and the current PR does allow the toolbar to be visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #20852, #21033
Nav Block submenus are only visible when hover or focus is within the submenu. This causes an issue in the editor where a Navigation Link in a nested submenu can be selected, but because focus is in a Toolbar or LinkControl (which are popovers), the submenu hides, and the user can no longer see what they're editing.
This PR adds editor only styles to solve that issue—when any Navigation Link block in a submenu is selected the list now receives the
.is-parent-of-selected-block
class name which is used to ensure the submenu stays visible.How has this been tested?
Manual Testing
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: