-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Block: Fix toolbar overlap on navigation links #21033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
An existing feature does not function as intended
[Block] Navigation
Affects the Navigation Block
labels
Mar 20, 2020
talldan
requested review from
ajitbohra,
jorgefilipecosta and
Soean
as code owners
March 20, 2020 04:15
Size Change: -12 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
talldan
changed the title
Fix toolbar overlap on next navigation links
Nav Block: Fix toolbar overlap on navigation links
Mar 20, 2020
This was referenced Mar 20, 2020
draganescu
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I also agree that z-index should be last resort in the editor, there already are impossible riddles (see inserter and block UI).
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20852
This is a somewhat brute-force attempt to resolve this issue by removed a z-index rule.
In testing, I couldn't see that removing this causes any issues. My suggestion would be that we try to live without z-index rules for as long as possible, unless we absolutely need it.
It might be that some themes require z-index rules, but then those should ideally be applied by the theme, because there's no way the core styles can get it right for everyone.
How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: