Add missing z-index override to the autocomplete component #19384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartczyz
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
|
I'm not certain this is a z-index issue, instead of trying to add to the z-index complexity, we should probably close the autocomplete popover once the focus moves out of the paragraph block. |
|
I agree with Riad. I think we should close the autocomplete menu after the focus changes. @bartczyz would you like to work on updating the PR to take that approach or maybe opening a different one? |
annezazu
added
[Type] Bug
|
Closing this PR out since the original problem was resolved: #18918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19353 by adding missing z-index override for autocomplete component.
How has this been tested?
Manual testing using:
Firefox 71
Chrome 79.0.3945.88
Safari 13.0.4
Types of changes
Small style updates.
Checklist: