Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward slash popover doesn't go away when clicking other icons #18918

Closed
mapk opened this issue Dec 4, 2019 · 6 comments
Closed

Forward slash popover doesn't go away when clicking other icons #18918

mapk opened this issue Dec 4, 2019 · 6 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Dec 4, 2019

Describe the bug
When I do that forward slash command to begin searching for a block, but then change my mind to click on another UI element in the page, the popover doesn't go away.

To reproduce
Steps to reproduce the behavior:

  1. Begin typing / followed by a word to bring up the popover.
  2. While this is visible use your mouse and click on another icon on the page.
  3. Observe that the popover doesn't disappear.

Expected behavior
When clicking on other UI elements, I expect the popover to disappear.

Screenshots

popover-of-doom 2019-12-04 10_01_45

Desktop (please complete the following information):

  • OS Catalina
  • Chrome and FF most recent builds
  • Gutenberg 7.0
@mapk mapk added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Dec 4, 2019
@mapk mapk changed the title Forward slash popover doesn't go away when clicking elsewhere Forward slash popover doesn't go away when clicking other icons Dec 4, 2019
@draganescu
Copy link
Contributor

I think this is a side effect of a recent change of the focus setting on the appender #18379

@draganescu
Copy link
Contributor

nope, testing showed that change not to be the problem, looking into some z-index things now.

@draganescu
Copy link
Contributor

@tellthemachines this commit appears to have moved the top bar popovers lower in the stack which created the behaviour found by Mark. No idea how to solve (z-index hell) but I thought you could come up with a wise solution!

@tellthemachines
Copy link
Contributor

@draganescu I would expect the forward slash popover to close when focus is moved elsewhere on the page, and that's unrelated to z-index. z-index only affects if it displays over or under the other elements, but even if it displays under the top nav stuff it's still open, and it should be closed. Will need some investigation to find out why this is happening.

@annezazu
Copy link
Contributor

annezazu commented Mar 3, 2021

Noting that I can't replicate this in Gutenberg 10.0.2 and am closing this out as a result. If this should be re-opened, please do so! Here's a video of the current behavior:

slash.command.mov

@annezazu
Copy link
Contributor

annezazu commented Mar 3, 2021

Sigh. Forgot to close ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants