Adds the new replace flow to the video block #19162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
draganescu
force-pushed
the
add/media-flow-video-block
branch
from
152aa55 to
f923d8f
Compare
Soean
requested changes
Dec 29, 2019
draganescu
force-pushed
the
add/media-flow-video-block
branch
from
f923d8f to
960fdaa
Compare
Soean
approved these changes
Jan 6, 2020
| @@ -47,10 +47,6 @@ class VideoEdit extends Component { | |||
| super( ...arguments ); | |||
| // edit component has its own src in the state so it can be edited | |||
There was a problem hiding this comment.
The src state was removed in #6820, so we can remove this comment.
| @@ -95,8 +90,7 @@ class VideoEdit extends Component { | |||
| const { attributes, setAttributes } = this.props; | |||
| const { src } = attributes; | |||
|
|
|||
| // Set the block's src from the edit component's state, and switch off | |||
| // the editing UI. | |||
| // Set the block's src from the edit component's state | |||
There was a problem hiding this comment.
We also can remove this comment, it's not valid since #6820
Soean
approved these changes
Jan 7, 2020
This was referenced Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a new replace flow offered by a component which is currently implemented in the Image Block. This PR implements the new flow in the Audio Block.
How has this been tested?
Tested locally.
Screenshots