Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in the Edit Media Toolbar Icon #17219

Closed
fabiankaegy opened this issue Aug 27, 2019 · 1 comment
Closed

Inconsistencies in the Edit Media Toolbar Icon #17219

fabiankaegy opened this issue Aug 27, 2019 · 1 comment
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Media & Text Affects the Media & Text Block [Block] Video Affects the Video Block [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@fabiankaegy
Copy link
Member

The icon to edit the image or video is different between different core blocks. For example the image block already has the new SVG icon, while the Video, Media-Text & Cover blocks still use the "Edit" dashicon.

I would suggest unifying these Icons to the new Icon first implemented in the Image Block to make it more clear how that action works. No matter which block you are using. The "Edit" dashicon is more general and can / will be useful to have for other operations in the future.

@talldan talldan added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Media & Text Affects the Media & Text Block [Block] Video Affects the Video Block [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take labels Aug 28, 2019
@Soean
Copy link
Member

Soean commented Jan 13, 2020

We now use the MediaReplaceFlow component in all media related blocks. See #19162

@Soean Soean closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Media & Text Affects the Media & Text Block [Block] Video Affects the Video Block [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants