Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reusable blocks being too tall #18902

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix reusable blocks being too tall #18902

merged 1 commit into from
Dec 5, 2019

Conversation

ZebulanStanphill
Copy link
Member

Description

Fixes #18901. The issue was caused by #18732 changing a height style rule to a min-height rule, while not changing the styling in packages/block-library/src/block/editor.scss that was intended to override it.

Screenshots

Before:
image

After:
image

@ZebulanStanphill ZebulanStanphill added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Regression Related to a regression in the latest release labels Dec 4, 2019
@ZebulanStanphill ZebulanStanphill mentioned this pull request Dec 4, 2019
Merged
6 tasks
draganescu
draganescu approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZebulanStanphill ZebulanStanphill merged commit da0b001 into master Dec 5, 2019
@ZebulanStanphill ZebulanStanphill deleted the fix/18901 branch December 5, 2019 14:00
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.

Reusable blocks are too tall
3 participants
@ZebulanStanphill @draganescu @youknowriad