Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Fields: Update test snapshot with the new checkbox implementation #16918

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

marekhrabe
Copy link
Contributor

Description

I have merged my PR #15688 onto master where it got an updated implementation of checkboxes from #16551 and that unfortunately broke test snapshots. This PR updates them.

My original PR should have been rebased before merging, despite the merge looking clean. Rebasing would have surfaced this.

Failed merge: https://travis-ci.com/WordPress/gutenberg/builds/122051161?utm_medium=notification&utm_source=email

How has this been tested?

Tested by running unit tests 😉npm run test-unit

@marekhrabe marekhrabe requested a review from talldan as a code owner August 6, 2019 05:03
@marekhrabe marekhrabe self-assigned this Aug 6, 2019
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo merged commit f52b01d into master Aug 6, 2019
@gziolo gziolo deleted the fix/custom-fields-test branch August 6, 2019 07:56
@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Aug 6, 2019
@gziolo gziolo added this to the Gutenberg 6.3 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants