[UI Components] resolve missing styles from checkbox-control component (#11089) #16551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
jasmussen
reviewed
Jul 12, 2019
| height: 16px; | ||
| margin: 0 4px 0 0; | ||
| outline: 0; | ||
| padding: 0 !important; |
There was a problem hiding this comment.
For anyone else reviewing this, this whole green section is largely copied from http://localhost:8888/wp-admin/css/forms.css?ver=5.2.2, so it is as it says on the bin, a copy of the CSS from wp-admin. So while it would be nice to refactor away the !important, this is a separate task bringing these components to all of wp-admin.
jasmussen
reviewed
Jul 12, 2019
jasmussen
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Really cool work! Works as advertised for me. This work will also benefit us when we at some point in the future can refactor to use the same components everywhere in WP-admin as oppposed to just the block editor.
Before:
After:
I left one small comment about vendor prefixes but other than that, 👍 👍
youknowriad
reviewed
Jul 12, 2019
Remove vendor prefixing and target svg.dashicon css
… CSS Co-Authored-By: Riad Benguella <[email protected]>
|
Congrats for the first contribution. |
youknowriad
added
the
First-time Contributor
5 tasks
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change affects the
CheckboxControlUI component:How has this been tested?
On Gutenberg playground and in the editor on:
macOS 10.14.5
Chrome 75.0.3770.100
Safari 12.1.1
Firefox 67.0.4
Screenshots
Types of changes
Fixes #11089
Checklist: