Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive issues & a dimming issue #1691

Merged
merged 4 commits into from
Jul 7, 2017
Merged

Conversation

jasmussen
Copy link
Contributor

This PR fixes an issue with the dimming layer on the cover image, and then it does a fair bit of rewriting of the sidebar code to make it work better on mobile.

It's still a bit of a work in progress, but I'm assigning reviewers early because the CSS is sort of gnarly and I'd appreciate insights.

Also — while working on this, I discovered that WordPress has already solved CSS bleed with a class called modal-open. It's pretty magical, and I would love it if we can apply this to the sidebar when on mobile. See more info here: #656 (comment) — but this should probably be done in a separate PR.

Steps to test:

  • Verify that the dimming layer on cover image looks right on all alignments
  • Verify that the sidebar works / looks well on desktop, including with all metaboxes open
  • Verify that the sidebar works well as a modal on mobile, including with all metaboxes open

@jasmussen jasmussen added the [Status] In Progress Tracking issues with work in progress label Jul 4, 2017
@jasmussen jasmussen self-assigned this Jul 4, 2017
@jasmussen jasmussen removed the [Status] In Progress Tracking issues with work in progress label Jul 5, 2017
@jasmussen
Copy link
Contributor Author

Actually this isn't in progress. I'm just expecting code review comments.

@aduth
Copy link
Member

aduth commented Jul 7, 2017

Just to clarify, by "modal", do you mean it should be expected that the sidebar covers the entire screen on mobile, including the admin bar? (This is what I am seeing)

@jasmussen
Copy link
Contributor Author

Just to clarify, by "modal", do you mean it should be expected that the sidebar covers the entire screen on mobile, including the admin bar? (This is what I am seeing)

Yes. Having tried various things, this is what seems to work the best for me. It fixes both an issue with scroll bleed, as well as an issue with sticky toolbars that may or may not be scrolled out of sight.

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants