Testing: Whitelist specific files for PHPCS #16772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Build Tooling
aduth
force-pushed
the
update/phpcs-file-whitelist
branch
from
b5fcd46 to
7f0a498
Compare
Soean
reviewed
Jul 28, 2019
Co-Authored-By: Sören Wrede <[email protected]>
aduth
force-pushed
the
update/phpcs-file-whitelist
branch
from
a7c9616 to
6123772
Compare
|
Out of curiosity, I looked to see if this had any impact on Travis build time. Control: https://travis-ci.com/WordPress/gutenberg/builds/120989406 There is effectively no difference. I think this is expected, however; the primary benefit here comes in environments which include files not previously excluded from PHPCS, but targeted at local development and also not present in Travis (e.g. the Playground's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #16753
This pull request seeks to improve the PHPCS linting to avoid testing files in folders for local development. It can often be the case, either with Parcel (playground) or Docker local
./wordpressfiles, that thenpm run lint-phpfile times out due to attempts to recurse deeply into these folder structures.We could exclude more files as done in #16753, but I chose not to because the locations of PHP files are well-known and limited, and because I'm not convinced (with testing from
-vverbose output of thephpcscommand) that the exclusions were actually effective.Testing Instructions:
Verify lint passes: