Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Ignore more transient directories for lint #16753

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 25, 2019

This pull request seeks to include additional directories in .eslintignore to further align between this file and .gitignore. Without these changes, there can be significant time wasted recursing into folders not intended to be scanned for ESLint violations.

Testing Instructions:

Verify lint passes:

npm run lint-js

For good measure, you may also verify that an intentionally-introduced lint error fails as expected.

@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Performance Related to performance efforts labels Jul 25, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add any of those entries to the .eslintignore file used internally in @wordpress/scripts package https://github.com/WordPress/gutenberg/blob/master/packages/scripts/config/.eslintignore? Maybe .cache folder would make sense.

@aduth
Copy link
Member Author

aduth commented Jul 26, 2019

@gziolo I hadn't considered it. I guess it depends what criteria we use to include files for ignore there; should it be limited to files which might be introduced by other scripts in @wordpress/scripts? The .cache folder is unique to Parcel, not a standard folder we would expect to find in most projects.

@aduth aduth merged commit c402014 into master Jul 26, 2019
@aduth aduth deleted the update/eslintignore branch July 26, 2019 12:54
@gziolo
Copy link
Member

gziolo commented Jul 26, 2019

@gziolo I hadn't considered it. I guess it depends what criteria we use to include files for ignore there; should it be limited to files which might be introduced by other scripts in @wordpress/scripts? The .cache folder is unique to Parcel, not a standard folder we would expect to find in most projects.

I need to update https://github.com/WordPress/gutenberg-examples to fully use @wordpress/scripts package and this will let us find the answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants