Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button isDefault isBusy hover #14469

Merged

Conversation

sbardian
Copy link
Contributor

@sbardian sbardian commented Mar 16, 2019

Description

CSS update for isDefault and isBusy buttons. This change is pertaining to issue #14296. The update seems to fix the issue.

Closes #14296

How has this been tested?

All tests pass running npm test

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@sbardian sbardian force-pushed the try/button-isDefault-isBusy branch 2 times, most recently from 72008a5 to 2e2dc6b Compare March 17, 2019 02:01
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbardian thank you for your contribution, it seems to fix the problem in my tests 👍

We have some duplicate code:
https://github.com/WordPress/gutenberg/blob/2e2dc6b198bbf3ed2611b41e4a706086ec38d2d2/packages/components/src/button/style.scss#L187-L192

Would it be possible to remove the duplication by adding the selectors &.is-defaul.is-busy,&.is-defaul.is-busy:disabled, and &.is-defaul.is-busy[aria-disabled="true"] to the code already existing ?

@sbardian sbardian force-pushed the try/button-isDefault-isBusy branch from 2e2dc6b to fc3367c Compare April 3, 2019 15:57
@sbardian
Copy link
Contributor Author

sbardian commented Apr 3, 2019

@jorgefilipecosta you are correct. I have this updated and it seems to still fix the issue. Thanks!

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for your contribution!

@jorgefilipecosta jorgefilipecosta merged commit 9b25cc7 into WordPress:master Apr 12, 2019
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Apr 15, 2019
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 15, 2019
aduth pushed a commit that referenced this pull request Apr 16, 2019
aduth pushed a commit that referenced this pull request Apr 16, 2019
@sbardian sbardian deleted the try/button-isDefault-isBusy branch April 16, 2019 19:40
This was referenced Apr 17, 2019
@youknowriad
Copy link
Contributor

I wonder if this is related to this regression #15029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button isBusy styles overwritten on hover/focus
3 participants